IPB

Google Frontpage Forums Unattended CD/DVD Guide
 
Reply to this topicStart new topic
> Disable category check boxes, Don't work correctly?
RJTPlomp
post Aug 21 2006, 12:57 PM
Post #1


WPI Enthousiast


Group: Members
Posts: 35
Joined: 10-December 05
From: Dordrecht, The Netherlands
Member No.: 82068
Country Flag


Checking or unchecking the check boxes (right) next to the category name don't work anymore in 5.3.

Roland
Dordrecht, The Netherlands
Go to the top of the page
 
+Quote Post
zorphnog
post Aug 21 2006, 02:32 PM
Post #2


Advanced Member
***

Group: Members
Posts: 427
Joined: 25-July 06
From: Charleston, SC
Member No.: 105938
Country Flag


@RJTPlomp: The category check box will check apps, but not uncheck them.

Checking a category box will check any unchecked items within that category. However, unchecking the category does not uncheck all the apps in that category. This may be something that needs to be changed.

Good catch RJTPlomp. thumbup.gif
Go to the top of the page
 
+Quote Post
zorphnog
post Aug 21 2006, 02:46 PM
Post #3


Advanced Member
***

Group: Members
Posts: 427
Joined: 25-July 06
From: Charleston, SC
Member No.: 105938
Country Flag


Definitely a bug. Here's the fix.

In check.js:
Function setUnchecked
CODE
else
{
    var chkbox = document.getElementById("chkbox"+i);
    var lbl = document.getElementById('lbl'+i);

    if (chkbox==null)
        return;
    if (forc[i]!=null && forc[i]=='yes')       //<------------add this line
        return;                                //<------------add this line
    chkbox.checked=false;
    lbl.className='txt';
    tabs++;
    uncheckChildren(i);
    if (DisableOnDepsNotMet)
        disableChildren(i);
    if (useExclusions)
        checkExclusions(i);
    tabs--;
}

Function checkCategory
CODE
if (isCategory(thisChk)) //If category checkbox was checked
{
    thisCat = thisChk;
    
    for(i=1; cat[i] != null; i++)
    {
        if (cat[i] == thisCat)
        {
            if (state)
            {
                setChecked(i);
                checkDeps(i);
            }
            else
            {
//                setUnchecked(i);            //<--------remove the "//" at the begining
                checkDeps(i);
            }
        }
    }
}
Go to the top of the page
 
+Quote Post
mritter
post Aug 21 2006, 04:28 PM
Post #4


WPI Co-Developer
Group Icon

Group: Software Developers
Posts: 552
Joined: 13-November 05
From: Bettendorf, IA
Member No.: 79628
OS: Vista Home Premium x64
Country Flag


See this reply:

http://www.msfn.org/board/index.php?s=&...st&p=550576

I disabled the fully un-check a category on purpose. It would cause forced items to become un-checked. Seems like a long-way-around-fix then manually uncheck items, but it prevents a lot of headaches.
Go to the top of the page
 
+Quote Post
mritter
post Aug 22 2006, 06:19 AM
Post #5


WPI Co-Developer
Group Icon

Group: Software Developers
Posts: 552
Joined: 13-November 05
From: Bettendorf, IA
Member No.: 79628
OS: Vista Home Premium x64
Country Flag


@Zorphnog: We were both correct. With all 3 updates together it works 100% again. I mis-read where you added the 2 lines. Attached is the working check.js.
Go to the top of the page
 
+Quote Post
zorphnog
post Aug 22 2006, 01:14 PM
Post #6


Advanced Member
***

Group: Members
Posts: 427
Joined: 25-July 06
From: Charleston, SC
Member No.: 105938
Country Flag


Ok, good. I was starting to get confused as to what you were talking about.
Go to the top of the page
 
+Quote Post
RJTPlomp
post Aug 25 2006, 03:49 PM
Post #7


WPI Enthousiast


Group: Members
Posts: 35
Joined: 10-December 05
From: Dordrecht, The Netherlands
Member No.: 82068
Country Flag


QUOTE (zorphnog @ Aug 22 2006, 09:14 PM) *
Ok, good. I was starting to get confused as to what you were talking about.


I was confused as well... but downloaded the new fix, tested it, and found out it works like magic again. Great, thx!

Ro

This post has been edited by RJTPlomp: Aug 25 2006, 03:50 PM
Go to the top of the page
 
+Quote Post

Google Frontpage Forums Unattended CD/DVD Guide

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



Lo-Fi Version Time is now: 23rd November 2008 - 04:13 AM
All trademarks mentioned on this page are the property of their respective owners
MSFN is not affiliated with Microsoft
Copyright © 2001-2008 msfn.org
Privacy Policy