Fixes and adjustments so far:

Since WPI 5,1 I always have this errormessage:



WPI loads the first time correctly, the second time I have this error.
WPI is on HDD e:/ and has ho entry in config.js.
Does WPI need to start from cdrom?

Hmm, when I just let the timer run and WPI should start the install, at the end of the countdown, I get this Error message:

EDIT: sadicq fixed it, see next post

Open timers.js and replace the line 62 with this:

Yeah man! That works perfectly. Now the install starts. Thank you very much!!!

Have been testing the 5.2 from DVD and had the following error opening WPI.hta with my .cmd file. Also when opening it right away from DVD. This appeared after making a ISO of it (strange because before there were no opening errors, I checked).

I'll explain:

First telling that my config.js is very large one, i've got 192 programs to select (maybe this is relevant) . And all i've done is downloaded 5.2 and past my Install folder in it and my config.js too.

Opening it before I made a iso of it did not showed any problems. I always start my WPI.hta by a .cmd file and it was not possible to open 5.2 this way without an error , so I tried to open wpi.hta right away on te DVD and that worked, but got the same error again.

My command to open wpi.hta is:





The Error that occurt:







Then it asked me if I want to resume the script on that page and I selected yes, WPI started normally then.
I made my selections (all 192) an started my installations.
All went well but....

-All .cmd file commands did not run from DVD.(EXAMPLE: I still use: cmd2[pn]=['%wpipath%Install\\Apps\\ICQ\\taskkill.cmd']
-Normally my config.js list takes 32 minutes to install all the software, now it took 50 minutes to compleet (20 minutes more, so I think it was struggling with something else while installing).
-The bug I had in 5.1 about not closing the installer after wpi finished is not in this verion, so that's OK now and taken care off.


After installation was done, and tried to open wpi.hta again manually from DVD this error occured:








I don't know what this all means, and I hope it is usefull information for you all.

Still have the original files where I made a iso from (C:\XPCD\WPI), openig wpi.hta from that original file does not give any errors (no error opening it with my command file (after changing the path) an no error opening the wpi.hta manually from C:\XPCD\WPI\WPI.hta).

Why can't I open wpi.hta on the DVD with my command file or manually ???? all other versions had no problem with this method.
The reason why I still use this command is that I first want to install al mainbord drivers and other drivers like audio and network adapter drivers before installing the software. In my $OEM$\$Docs\All Users\Menu Start I made a folder "Start WPI" with the commandfile (shown above) to start wpi.hta from there.

After unpacking the iso that gave the errors (explained above) to C:\XPCD I run WPI.hta manually and got no errors opening it (so that made me believe the iso was OK), went to options and selected debug mode (2) and it said that the software would not really be installed that way, this wasn't the case... all installs really took place and installed perfect (even the .cmd commands worked in the debug mode, so that's nice). But still the installation time was also this way 50 minutes (20 longer then version 5.1).

My conclusion is that 5.2 installs OK from harddisk, but gives problems when burning to DVD and install from DVD (in my situation anyway).
Also the install time increased with 66% that's something to look at, and verify with other testers (maybe it's because of the new installer you are using).

I also found that the system was extremely slow after this installation (both ways, debug way and after install from DVD)

I have got this advice from MRitter yesterday:

First thing to try is this in WPI.hta, line 43



Take out 1 of the slashes after file:/// Try with only 2.

But thats already done by himself I think before going public with 5.2, so that is no solution for this problem.

I'll hear from you people....

Hello
Sorry for my english i'm French

I tri WPI 5.2 but i cannot exit (only way is Taskmanager --> kill).
Can you help me ?

Hmm, I only can confirm the second bug that Pilek posted. When I run WPI from HDD, it just runs fine. But when I burn it on CD/DVD I get the same errormessage that he gets. And if I click it away, WPI continues running. I did not test, if the process is much slower, but my cmd files get executed, even if the error came up.

My .cmd files all for 90% taskkil.cmd to kill processes after installing a program, that doesn't work here.
I think that the error WPI gave me is resposible for not loading the files to compleet taskill.

Ok... I know this sounds stupid, but I spent 2 hours on this bug ...
Open patchFile.js in notepad and replace
with Somebody forgot to comment it out ....
Attention: Apply this fix on a clear WPI as the line that is not commented has already modified your WPI if you ran it from hdd.
The problem showed up only when you were running WPI from CD because it was read-only and the script could not modify the files ....
Note that the line you are commenting is just an example and it is not needed by WPI. Actually it's doing just the opposite.

See Forced install enhancement. I posted a fix for what I consider a bug with the FORCE install checkbox issue. You can do a diff on the files to see the changes.

Ok sadicq, you again solved the problem. The bug is gone. Now sometimes when I start WPI from CD/DVD, I get the following bug:



The error message comes up, when WPI closes and the installer window opens. But it only comes up sometimes, not every time. I think it has to do with the loading from CD, because it takes much longer than from HDD. I already noticed this bug with WPI 5.0. And since WPI 5.0, loading WPI from Disc drive takes much longer than before. I think it is 10-15 seconds. With WPI Lite 1.2 it was about 3 seconds. Now as it says Theme=Royale, I tried with Glossy theme, but still the same error message, just "Theme=Glossy" now.

Open patchFile.js in notepad and replace
with

Will try this later today after work, thanks already sadicq.

Open installer.js and look at this line:

Try increasing that value and see if the error still appears.

Ok, here's the solution (the post before was just to determine the source of the problem, but I'm pretty sure that that was the problem).
In installer.js, replace
withAnd this will work every time.

Yep, once again sadicq is right:
I've only tested the installer from HDD and found the 100ms value to be enough, but did not think about you guys still burning disks
You may want to use sadicq's fix:

One More, sadicq !
It looks like the file patcher is not yet used to update the themes. So it should not even be called from wpi.hta.
Anyway, that example function call was meant for 5.1 and has no reason to be anymore.
Further, since there is no more class="txt" in wpi.htm, it has no effect at all! Only triggering strange bugs!
Because of this, you don't even need to "Apply this fix on a clear WPI". Just comment the line out as showed by sadicq. In any case.

By the way, the opText class, which exists in wpi.htm since at least 5.0, never had any definition in wpi.css!
So it seems it's useless altogether as nobody noticed it! One more simplification to implement in the themes!

Actually, this way you're breaking the process that finds the command line parameters:
Strangely, document.location features these 3 /s: "file:///".
You can check it by yourself by inserting this line in the code and watch the result:

So, as the current 5.2 download only features 2 /s, there's a bug there too.
BUT this should NOT trigger any other bug than not being able to use command line parameters anymore.
More specifically, this is not related to the bugs discussed above.

Salut Fred
If you problem occurs during installation, one possibility is that you may have a program launched by WPI that is still running (the last uncheck one in the installer).
WPI is waiting for it to terminate before closing itself.

Is it possible for all other people that read this bug topic, that all replacement are set in one message so it's clear wat we must adjust.
I should say Kel's announcement of this topic should keep the fixes updated, or one of you sadicq or Djé .
Because now there are more bugs been fixed.
Just to be clear for everyone.

Thanks

Very good idea. I'd also say that this is Kel's job .
But since you've posted (and experienced) some of them, you may help him a lot by summarizing what is fixed for you, and help us debugging by making another list of what remains to be fixed (again, only for your problems is enough).

Yeah sadicq, that solved the problem. But I do not have to post this, because we did not expect anything else, or did we?
So if the errors of Pilek are solved, what about releasing WPI 5.2.1, because with WPI 5.2 there is no way to make an install from Disc drive.

Already talked to mritter about that problem.

Bugs reported so far

1. Progress bar wrong id. Link Fix [Sidenote: you may also remove that line ...]
2. Uncommented line for theme update. Link Fix [Sidenote: the file patcher should be modified because it generates those errors when it is run from a read-only media]
3. Not a bug, but an enhancement. Link & fix
4. Pause time issue. Link Fix
5. Command line parameters issue. Link Fix sent to mritter.
6. A bug ... Link No fix yet [I couldn't reproduce it yet].
7. Installation slowed down. Link No fix yet [I couldn't reproduce it yet].

I hope these are all the bugs that were reported so far.
Thanks Dynaletik and Pliek for the bug reports.

The bug most probably comes from this line:
on line 126 of generate.js.

@wixfigura, can you run a test after inserting the following line just before the one mentioned above:
And tell us what the message box says?
Can you also tell us if you have a $winnt$.inf in your system32 directory?
And if not, if you know why you haven't?

I have a problem with the new WPI 5.x.
I guess it's a known problem but can't find a solution anywhere.

In my config.js there are allot of 7z sfx installers.
After they are extracted they start installing on their own.
The problem is that this new WPI doesn't wait for them to install....
It proceeds with the next item therefore not installing everything properly.

Is there a fix or something for this?

Oke I'm back, I have been testing and the results are good...

I'll tell exactly what I have done, accourding to the errors WPI gave me by starting .

I have modified these files The numbers are from sadicq list of fixes: (Thanks for the list sadicq)

2. Uncommented line for theme update.
Link Fix

Open patchFile.js and replace


with



3. Not a bug, but an enhancement.
Link & fix


4. Pause time issue.
Link Fix

In installer.js, replace


with



5. Launching from a .cmd file and start cd/dvd problem: I've got this by mail from mritter today (it worked).
In wpi.hta line 43 replace


with


See if that cures the launching from cd/dvd problem with a .cmd file (it worked for me)..

7. Bug that slows down the install time is related with these other ones (don't no witch one).
All 192 programs installed perfect, and the installation time of these 192 programs was again 32 minutes (like it always was, so the "bug" that gave 20 minutes extra longer install. time is also solved).

And at last one little thing took place, the time for showing up my rebootscreen (called from a .cmd file) took over 90 seconds to appear. To be specific, my desktop got cleaned 90 seconds after the installer screen dissapeard, and almost right after that... the shutdown screen poped up.

That .cmd file looks like this.


That is the onely thing in my case that needs to be looked after.
I hope i've given all the right information, if you guys need more ...let me know.

Removed ....

I still get this error.

*just copied config.js from my old WPI lite 1.2



Seems like compatibility issue. seems like I have to manually input every program again. could you save me from hours of typing Kel?

I have all the known fixes worked in to the latest 5.3 beta. Sadly, when I was testing with other people's config files I found a few more errors not yet reported. Mostly cosmetic but still a bug.

so you have fixed the error I'm having? if not, do you need my config.js ? I'll upload it if you need it to fix the issue.

thanks in adv

Line 1644 is in the saving of the useroptions.js file. The function name has nothing to do with the line number. What are you doing when this error comes up? If you are using your old 1.2 useroptions.js file, then that is the problem. They are not compatible. Try renaming it so you don't lose it, then start WPI again, go in to Options, it will save a default set. Close. Open again and try to reproduce the error.

To be clear I've used fix 2, 3, 4, and 5 (5 was mailed to me by mritter) and problem 7 (longer install. time, no fix still) was related with the other ones (don't know witch fix repaired problem 7 but it's gone after using fix 2,3,4,5), just these four fixes were relevant for my errors.
Today I wil adjust this nice working iso with bugfix 1 and test again (although I did not had that bug).
I will just test to be sure that it can be used by everyone without getting new errors (related too applying fix number 1).

For myself, I have onely one bug to be fixed.
The time for showing up my rebootscreen (called from a .cmd file) took over 90 seconds to appear.
To be specific, my desktop got cleaned 90 seconds after the installer screen finished and dissappear, and directly after that... the shutdown screen poped up, this dalay "must" be fixed.

We talk later,........First work, then hobby.

I'm not using useroption.js , I just copied config.js file from my 1.2 to 5.1 or even 5.2 and this error occurs.

If i take out the config.js from the WPIScript folder and run 5.2 , it works fine.

any idea? I'd really like to avoid manually inputting everything one by one

*EDIT*

After playing with config.js , I've found out error occurs when there are these lines. probably something to do with conflict of word 'THEME' ??



*EDIT2*

seems like cat[pn] cannot be 'theme' else it'll give the error because of conflict with that line. Changed it to something else and it works now.

i am getting this error before WPI starts.. anyone has a fix for this.. thx

I had the same error.
aply fix 2,3,4.
Asuming you are opening WPI.hta from CD/DVD.

2. Uncommented line for theme update.
Link Fix

Open patchFile.js and replace

with



3. Not a bug, but an enhancement and should be done by everyone.
Link & fix


4. Pause time issue.
Link Fix

In installer.js, replace

with


See if that works , it did for me..

report your results..

Just got info from mritter about this adjustment.
Iit's not a final solution mritter is still tuning this bug, but for now it works for me and check if this is also working for any of you.

From his mail:


5. Launching from a .cmd file and start cd/dvd problem (it worked).
In wpi.hta line 43 replace

with


So soon this will be updated.

Thanks in advance Mritter.

[Edit]: I've just seen Pliek's above post. So we all agree on that point.


But that completely breaks the command line arguments parser!

We've already talked about the 1st replace instruction, so let me explain the second one:
It prepares further the WPI path to be fed in the next regexp pattern by replacing the slashes of the URL by (escaped) backslashes.
In other words, it transforms the URL into a Windows path (with escaped backslashes):

fullpath:

CODE

file:///W:/WPI/WPI.hta

replace("file:///","")

CODE

W:/WPI/WPI.hta

replace(/\//g,"\\\\")

CODE

W:\\WPI\\WPI.hta

But replace(/\//g,"\\ <file:///> ")

CODE

W:\ <file:///> WPI\ <file:///> WPI.hta

?????

Why would you replace the backslashes of the path with this cryptic "\\ <file:///> "?
What is the purpose of it?
How does it fit in the command line arguments parsing process?

Moreover, if I well understood that it does fix Pliek's CD/DVD problem, what is still unclear is HOW does it fix it?
Notwithstanding this basic understanding problem, we can't just fix something by breaking something else.

IMHO, only by finding the root of the problem we will be able to design a satisfactory solution.


ps:If you want me to explain further the command line arguments parser code, feel free to ask.

To be honest Djé I don't know anything of repairing, enginering these scrips...I just don't.
This is what mritter mailed me, and I am glad to test it out.
Sorry that I can not be of any help in there, just be glad that you guys are so in too this to help us (more than ones already).
So keep going and I will be glad to test it.
I also report Kel that this last "fix" is not a final, and that he needs to change that by saying so in the overall fix report (first message of this topic).
Now I wil test all the fixes together, so 1,2,3,4,5 (before I did not test fix 1).
Let you know.

No problem You're of a lot of help by finding these bugs and testing the fixes.
Would you mind summarizing on this specific error:
Can you just confirm the error message that you still get?
Is it the one with line 42 or the one with line 43?
If you can post an image of it, that would be the best.
Together with the content of the incriminated line (with whatever fix you used or not).

Thanks!

Oke but now I'm testing with fix 1,2,3,4 and 5, after that test I wil do another test with onely fix 1,2,3,4 and then I wil report te error specificly to you.
This will be later today, but before the evening.
Till then.

Thanks Kel for adjustment of the overall bug fix report.

Test with fix 1,2,3,4,5 went without errors, onely after install is done and the install screen is also gone the process mshta.exe stands for 90 sec. on 100% cpu load. After that time my .cmd file cleans up the desktop and all is fine.

Will test now onely 1,2,3,4.
Let you now.....later.

Tests with fix 1,2,3,4 is finished, and no errors this time.
Must be the combination (never tried Fix 2,3,4 without fix 5) so the error is fixed by 2,3 or 4.

Here is a full report of my WPI 2.5 history:

Fase1:
I first downloaded 5.2 with the 2// already in WPI.hta (although these 2// seems to be not right).

Burned a iso and could not open from DVD without error in WPI.hta line 42 and 43.




And with this installation all my .cmd files were not executed.

Fase2:
Then again started with a clean WPI and tested with fix 2,3,4,5 the slowdown bug was gone (install. time was normal again so that was fixed) and al .cmd files were executed now (so that was also fixed), only the shutdown time was 90 secs now instead of 32 (process mshta.exe was running up my CPU load to 100% for 90 seconds even when the install screen was closed, then my command went on, cleaned up and then shut down my pc). There were no errors in this test.

Fase3:
Then again started with a clean WPI and tested with fix 1,2,3,4,5 The results where the same as fase2.

Fase4:
Then again started with a clean WPI and tested with fix 1,2,3,4 and this was the first time without putting in fix5. So I expected the errors again in WPI.hta line 42 and 43.
But this is not the case, the test went on perfect and installtime and command file executions where perfect too.
So the fix (in my case) for error 42 and 43 were fixed by fix 1,2,3 or 4 and it seems that fix 5 is not needed.
Only one thing that needs to be fixed is the cpu load of mshta.exe that is responsible for the 90 seconds delay.


That's it, as long as there are no new fixes, I will no longer test because i've had al combinations and fase 4 seems to be the best I can get right now.

I will wait and hope there are some solutions to this bug soon....

YUP!!!!!!! working fine after those modifictations.. thx

Hi guys,

I'm not sure if this is a bug or it's supposed to be this way...

Description: I JUST started using the "Condition" variable in my config.js to check to see if the executable is on the CD, i.e


This works perfectly when I test the ISO I build (the application disappears / appears accordingly ) however, it is ALWAYS hidden when I launch WPI.HTA in "editing mode" (i.e. straight off my HD when I am adding a new app or changing something, etc)

I have this line on all my applications, so essentially, when I double click on WPI.hta on my HD to edit, nothing shows up, however, when I build the iso and mount it, all works as it is supposed to...

Is this normal?

BTW, Thanks for the fix about the uncommenting! (#2 I believe)

It is normal ... you see, %CDROM% won't work if you run it from hdd in most of the cases. But you can trick it if you layout your drive the same with your DVD (make sure all the folders relative paths to the drive are the same with the cd you want to put them on). So, when you edit your config, try moving your applications in DRIVE:\Applications\ and it should work.
Edit: I'm writing from memory, so I'm not 100% sure.

Hey....

I get this error on WPI 5.2 when I save the settings after I add an .mp3 song to the audio player....

Just a wish: Please release WPI 5.3 as a Beta first, and if there are now bugs in it, call it final.

@lennierv
What's the exact name of the melody you are trying to add?
WPI has some problems with special chars.

I get similar error in Installer.hta . but in Line 55 . I couldn't get a screenshot now, but I'll try to get it.

Also, Programs don't install in right order. I had WinRAR install before priority #1 program (which is MS office)