Help - Search - Members - Calendar
Full Version: Disable category check boxes
MSFN Forums > Member Contributed Projects > Windows Post-Install Wizard (WPI) > Bug tracker

   
Google Internet Forums Unattended CD/DVD Guide
RJTPlomp
Checking or unchecking the check boxes (right) next to the category name don't work anymore in 5.3.

Roland
Dordrecht, The Netherlands
zorphnog
@RJTPlomp: The category check box will check apps, but not uncheck them.

Checking a category box will check any unchecked items within that category. However, unchecking the category does not uncheck all the apps in that category. This may be something that needs to be changed.

Good catch RJTPlomp. thumbup.gif
zorphnog
Definitely a bug. Here's the fix.

In check.js:
Function setUnchecked
CODE
else
{
    var chkbox = document.getElementById("chkbox"+i);
    var lbl = document.getElementById('lbl'+i);

    if (chkbox==null)
        return;
    if (forc[i]!=null && forc[i]=='yes')       //<------------add this line
        return;                                //<------------add this line
    chkbox.checked=false;
    lbl.className='txt';
    tabs++;
    uncheckChildren(i);
    if (DisableOnDepsNotMet)
        disableChildren(i);
    if (useExclusions)
        checkExclusions(i);
    tabs--;
}

Function checkCategory
CODE
if (isCategory(thisChk)) //If category checkbox was checked
{
    thisCat = thisChk;
    
    for(i=1; cat[i] != null; i++)
    {
        if (cat[i] == thisCat)
        {
            if (state)
            {
                setChecked(i);
                checkDeps(i);
            }
            else
            {
//                setUnchecked(i);            //<--------remove the "//" at the begining
                checkDeps(i);
            }
        }
    }
}
mritter
See this reply:

http://www.msfn.org/board/index.php?s=&...st&p=550576

I disabled the fully un-check a category on purpose. It would cause forced items to become un-checked. Seems like a long-way-around-fix then manually uncheck items, but it prevents a lot of headaches.
mritter
@Zorphnog: We were both correct. With all 3 updates together it works 100% again. I mis-read where you added the 2 lines. Attached is the working check.js.
zorphnog
Ok, good. I was starting to get confused as to what you were talking about.
RJTPlomp
QUOTE (zorphnog @ Aug 22 2006, 09:14 PM) *
Ok, good. I was starting to get confused as to what you were talking about.


I was confused as well... but downloaded the new fix, tested it, and found out it works like magic again. Great, thx!

Ro
Google Internet Forums Unattended CD/DVD Guide
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.