[gora]

Thanks!
At unpacking NSIS installer (7z910.exe), flashes the window in which text too is not located, but it is impossible to make a screenshot. Look at it, please.

This post has been edited by gora: 11 May 2010 - 01:37 AM

[nitro322]

OK, just for the record, this has not been a quick and easy update. But, I think it'll be worthwhile at least, and I hope all of you agree.

I found a few more concerns while working on the code earlier tonight, and so I decided to do my full regression testing after all. Good thing I did - I found quite a few problems, mostly in edge cases, but still... I want this to be as stable as possible. I fixed all of the problems I found and added a few more enhancements here and there as I thought of them.

I'm also pleased to say that I was able to work in the "better success criteria" previously discussed. It's not perfect, but it's a big step forward. The way I ended up doing it was actually pretty simple once it came to me - if extracting to an existing directory, check the timestamp before and after extraction and then compare it. If they match, the extraction (probably) failed. It's not exact, though - it'll catch most files if they are overwritten, but not if the user decides to skip the files. It'll also fail if all files are extracted into subdirectories (since the parent directory is never modified), and, for whatever reason, some utilities just don't seem to update the directory modification time, even though files in that directory seem to be getting overwritten. Anyway, like I said, it's not perfect, but it's an improvement. Suggestions for future improvement are welcome.

I still have some concerns about the new 7-Zip .exe resource extraction. I ended up reordering 7-zip extraction; it's now pushed back until the end of the External PEiD scan (which itself comes after the Deep and Hardcore scans). This should hopefully give other, more appropriate utilities the chance to operate first before 7-Zip rips it up.

With all these changes, I'm posting one more beta. If at all possible, please download it, throw as many test files at it as you can, and let me know how it works (good or bad). Pending any negative feedback, the only thing I have left to do is include some translation updates (gora - I can include your Russion translation if you send it my way), which I'll take care of tomorrow night, then package and upload the final release.

Here's the new beta link:
http://www.legroom.n...eta2_noinst.rar

And the list of final changes (might be some dupes):

  Changed 7-Zip unpacking behavior;
          now attempts brute force extraction only after External PEiD scan;
          change due to aggressive .exe resource extraction in new versions
  Changed following formats to call 7z by name (also see 7-Zip debug comment):
          bz2, chm, gz, tar, Z
  Fixed InstallShield 5.x regression from 1.6 preventing successful extraction
  Fixed bug in extraction of non-TAR LZW compressed files
  Removed Windows NT 4.0 support from installer
  Removed debug output for 7-Zip, arj, hlp;
          buffers output, preventing proper user feedback and input prompts
  Updated success/fail detection to check output directory timestamp;
          can detect cases where files are overwritten, which old method missed;
          will still consider failed if user chooses not to overwrite files,
          or if all files are written to a subdirectory of the output directory
  Updated RPM and DEB support to extract interim CPIO and TAR files
  Updated FEAD support to workaround read-only permission issue
  Updated some UniExtract window sizes for better internationalization support
  Updated AutoIt to 3.3.6.1 and replaced deprecated _ArrayCreate UDF
  Updated MSI WCX to 1.2.1

Thanks for the feedback everyone. Please stick with me one more day so we can get this wrapped up.

This post has been edited by nitro322: 11 May 2010 - 12:02 PM

[nitro322]

gora, on 11 May 2010 - 01:36 AM, said:

At unpacking NSIS installer (7z910.exe), flashes the window in which text too is not located, but it is impossible to make a screenshot. Look at it, please.

If you're referring to the splash text windows (eg., "Extracting files from: NullSoft Installer installer"), I actually increased the width of these last night. I don't remember if it was before or after I released the beta, though. Give it a shot with beta2 and let me know how it looks. It seems ok to me.

[gora]

nitro322, on 11 May 2010 - 01:49 AM, said:

Give it a shot with beta2 and let me know how it looks. It seems ok to me.

Testing InstallExplorer Installer

Òåñòèðîâàíèå InstallExplorer èíñòàëëÿòîðà

The Russian text more long also is not located in single line (two lines turn out) and the second line is visible not completely on a vertical.

Òåñòèðîâàíèå InstallExplorer
èíñòàëëÿòîðà

What means "merge module"? An example?

[nitro322]

gora, on 11 May 2010 - 02:45 AM, said:

The Russian text more long also is not located in single line (two lines turn out) and the second line is visible not completely on a vertical.

Òåñòèðîâàíèå InstallExplorer
èíñòàëëÿòîðà

What means "merge module"? An example?

Alright, I'll look into this.

Merge modules (in this context) are Windows Installer components. Details: http://msdn.microsof...28VS.85%29.aspx

[gora]

1 Extraction in an existing folder (the repeated extraction, the first extraction occurs without errors).


Click "OK"


Click "OK"



The text in last screenshot: "Specified the file does not exist. To open as a new file?"
Note: EmEditor - the text editor by default in my system.


2




Extraction with acknowledgement became less convenient, many additional operations:
- To shift window UE, to see entry line in a console window
- To click on a console window, to return it focus
- To be switched Rus-> Eng the keyboard
- To press "A"
- To press "Enter"

[nitro322]

gora, on 11 May 2010 - 11:36 PM, said:

The text in last screenshot: "Specified the file does not exist. To open as a new file?"

Weird. I tried downloading adblockpro.exe, but I can't replicate the problem. Repeated extractions exit successfully. Regardless, though, there will be cases where this fails; as I mentioned in the changelog, detection isn't perfect due to a number of factors.

As for the "file does not exist" problem, I can't think of what may cause that. The file should always be there. Even for formats that I can't log (including 7-Zip now) it should at least contain a line stating something like "Extraction of 7-Zip archives cannot be logged." Can you do me a favor? Repeat the test that failed, then manually check to see if the debug file exists. Maybe it's an issue with the path (are you using an environmental variable in the debug location?), or maybe your editor isn't liking the way it's being called.

Edit: The debug file is launched with a ShellExecute command, which should open it in whatever edit Windows opens .txt files in by default. If the debug file does exist, try pasting the full path of it into the run box (just the file path, no editor command) and verify that Windows opens it properly in your editor.

gora, on 11 May 2010 - 11:36 PM, said:

Extraction with acknowledgement became less convenient, many additional operations:

I agree that this can be less convenient, but it's safer and more accurate. This is actually how I intended extractions with 7-Zip to function all along, the previous behavior was implemented because of this bug in 7-Zip. Since I couldn't log, I told 7-zip to force skipping existing files. After giving that decision a lot of additional thought, plus with the need to better handle overwrite detection, for the release I decided that it's more important to have full feedback and overwrite prompts for 7-Zip than debug logging. Once Igor fixes the issue in 7-Zip I'm going to add logging again, but the user prompt behavior will stay.

It's a feature, not a bug, although it may annoy some people.

Until I get a better system in place of handling i/o, the separate cmd Windows are the best option available. The primary goal for v2.0, whenever that may happen, is a revamped UI that integrates cmd output and prompts into the main UniExtract window. At that point the inconvenience factor will drop significantly, but until then the cmd windows are here to stay.

This post has been edited by nitro322: 12 May 2010 - 12:09 AM

[gora]

nitro322, on 12 May 2010 - 12:07 AM, said:

Can you do me a favor? Repeat the test that failed, then manually check to see if the debug file exists. Maybe it's an issue with the path (are you using an environmental variable in the debug location?), or maybe your editor isn't liking the way it's being called.

After a window 2 I see in a folder %TMP% 2 files of the identical size:

c:\DOCUME~1\gora\LOCALS~1\Temp\uniextract_temp.txt
c:\DOCUME~1\gora\LOCALS~1\Temp\uniextract.txt

But uniextract.txt I cannot look at a file, the system writes "There is no access or the file is already used"! The file uniextract_temp.txt normally opens and contains log

After pressing "ÎÊ" in this window 2 file uniextract.txt disappears also its editor simply does not find. In version 1.6 of such problems is not present, log file opens normally.

[nitro322]

1.6.1 is done. Download links and final changelog for the release version is available in the announcement thread. Thanks to everyone that provided feedback.

gora, on 12 May 2010 - 12:59 AM, said:

After a window 2 I see in a folder %TMP% 2 files of the identical size:
<SNIP>
In version 1.6 of such problems is not present, log file opens normally.

gora, I'm afraid I still can't replicate this, or even offer an explanation as to why it happens. You should never see that second _temp log; it only gets written very briefly in the event of a failed extraction, then gets moved back to the main debug file. This should happen pretty much instantly, and it happens before the Extraction Failed prompt is even displayed. That it doesn't happen with 1.6 is even weirder, because I didn't change anything at all in that part of the script.

Maybe I'm having trouble replicating your problem because I changed something between beta2 and the final version. I did make a few more tweaks, but nothing in particular that I can think of that might cause this. Go ahead and try the final version and let me know if you see any difference at all. If you do still have the problem, please provide the contents of your UniExtract.ini file (so I can try to match your environment as much as possible) and let me know what specific file you're trying to extract (direct download link would be a big help).

Everyone else - are you experiencing the same behavior gora reported? Please let me know.

[gora]

With Latest Stable Version - 1.6.1 these problems are not present.

[nitro322]

gora, on 12 May 2010 - 02:51 AM, said:

With Latest Stable Version - 1.6.1 these problems are not present.

Awesome, thanks for the update.

[gora]

The bug remained:

English


Russian


After little change:

Quote

splashtexton($title, t('TERM_TESTING') & ' InstallExplorer ' & t('TERM_INSTALLER'), 350, 50, -1, $height, 16)

Edit





1 the file name was not located
2,4 it is not translated
3 it is too low checkbox

This post has been edited by gora: 13 May 2010 - 10:39 AM

[gora]

flashplayer_10_ax_debug.exe (Adobe® Flash® Player ActiveX Installer) is not extract.

[gora]

Is not extract:

adblockpro.exe
http://www.adblockpro.com/download.htm

ccsetup227.exe
http://www.piriform....leaner/download

install_flash_player_ax.exe
http://fpdownload.ad...h_player_ax.exe

IEPro2.4.9.exe
http://files.brother.../IEPro2.4.9.exe

[wazer]

I have made an silent installer in english, if there should be any that wanna use it.

I must admit i love nitros tool. I use it almost everyday.



Here's a online virus check its clean..

http://www.virustota...e72a-1274111079

DOWNLOAD
http://www.mediafire.com/?zxjmwjzxd0x

[nitro322]

gora, on 13 May 2010 - 12:12 AM, said:

The bug remained:
<SNIP>
After little change:

Quote

splashtexton($title, t('TERM_TESTING') & ' InstallExplorer ' & t('TERM_INSTALLER'), 350, 50, -1, $height, 16)

Noted.

gora, on 13 May 2010 - 12:12 AM, said:

1 the file name was not located
2,4 it is not translated
3 it is too low checkbox

Can you clarify point 1? You say the file name is not located, but I don't know what file you're referring to. From the image it looks like the text is too wide for the screen, which would be more difficult to fix in Inno Setup than UniExtract itself.

2,4 - noted

3 - this is a known problem. Unfortunately, there's no easy fix (best I can tell) as it'll require completely rewriting that custom Inno Setup options page. I'm going to try to get that fixed for the next release.

gora, on 17 May 2010 - 09:13 AM, said:

Is not extract:
adblockpro.exe, ccsetup227.exe, install_flash_player_ax.exe, IEPro2.4.9.exe

adblockpro.exe seems to work for me, but it suffers from the problem described here, where Install Explorer isn't being used instead of 7-zip to extract it.

others - same problem, but Install Explorer is failing, and it's not falling back to 7-zip like it should. Definitely needs to be fixed.

[gora]

nitro322, on 29 May 2010 - 08:39 PM, said:

Can you clarify point 1? You say the file name is not located, but I don't know what file you're referring to.

OK
This line will not go mad completely in a window:
PREFS_LABEL2 = "Ýòè îïöèè ìîãóò áûòü èçìåíåíû ïîñëå èíñòàëëÿöèè ïóò¸ì ïðàâêè ôàéëà UniExtract.ini."
File name (UniExtract.ini) is cut off.

[nitro322]

gora, on 30 May 2010 - 11:01 PM, said:

This line will not go mad completely in a window:
PREFS_LABEL2 = "Ýòè îïöèè ìîãóò áûòü èçìåíåíû ïîñëå èíñòàëëÿöèè ïóò¸ì ïðàâêè ôàéëà UniExtract.ini."
File name (UniExtract.ini) is cut off.

Cool, thanks. That's what I was thinking based on the screenshot, but I wanted to verify I wasn't missing anything else.

[gora]

2 nitro322
This bug 7-Zip is already fixed (as has answered ipavlov). When you plan to update UE?

[Dumpy Dooby]

If TRID can detect MSIs created with Wix, then you should use dark.exe to decompile the MSI file. This should be preferred over MsiX.