Jump to content

Welcome to MSFN Forum
Register now to gain access to all of our features. Once registered and logged in, you will be able to create topics, post replies to existing threads, give reputation to your fellow members, get your own private messenger, post status updates, manage your profile and so much more. This message will be removed once you have signed in.
Login to Account Create an Account



Photo

Modified SYSDM.CPL 4.90.3001 for 98SE

- - - - -

  • Please log in to reply
115 replies to this topic

#26
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

I'm working on the final version right now. :w00t:

Thanks loblo, Open Watcom seems to do the trick with SYSDM.CPL renamed to .DLL :thumbup

I will edit this post with a link to the "Final" version for testing as soon as I'm done.


EDIT:
Here's a link to the Final version.
{Old link to Bugged File Removed}

File version number has been increased to 4.90.3002, but note that this file is customized for 98SE ONLY.
Do NOT use with Windows ME. It contains nothing useful for Windows ME and has ME-specific items removed.

All changes to this file have been cosmetic, but it should be tested in various situations, such as: removing and installing devices/drivers, and enabling/disabling items on the various "File System" dialogs to be sure there are no unseen side effects.

Report any and all bugs here.

Edited by LoneCrusader, 08 November 2012 - 11:54 PM.



How to remove advertisement from MSFN

#27
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag
I found New Hardware box is not centered, but is in the upper left corner. Other than that, its eligible for the SP. Thanks. I have tried the original version 4.90.3001 and did not find this bug. I have also tested another modded version and get the same results. The bug lies in version 4.90.3001 somewhere within the mod.

Edited by PROBLEMCHYLD, 06 November 2012 - 06:37 PM.

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#28
jumper

jumper

    2014 All-American Masters HJ'er

  • Member
  • PipPipPip
  • 498 posts
  • Joined 21-January 11
  • OS:98SE
  • Country: Country Flag
Open Watcom looks like the winner! :w00t:

I produced a "final" at about the same time this afternoon using VC6. It's functionally identical to yours, but I was unhappy with the 19KB of bloat VC6 added.

Your "final" is actually 160 bytes smaller than two days ago and looks great! Well done. :thumbup

@PC: I count 14 dialogs with "New Hardware" in the caption. Which are you referring to and how can we reproduce it?
Design feedback requested:
IHAtool - IpHlpApi tester; call various functions and report results
--status-> framework is solid; 22 api's fully supported; preview release coming soon
ComDlg32 wrapper - ComDlgEx meets IpHlpApi wrapper
--status-> PrintDlgExW working in latest SumatraPDF 8^)
Future projects: ImportPatcher40 - dialog interface; Kexter - IP40+Ktree+Kexstubs

#29
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag

Open Watcom looks like the winner! :w00t:

I produced a "final" at about the same time this afternoon using VC6. It's functionally identical to yours, but I was unhappy with the 19KB of bloat VC6 added.

Your "final" is actually 160 bytes smaller than two days ago and looks great! Well done. :thumbup

@PC: I count 14 dialogs with "New Hardware" in the caption. Which are you referring to and how can we reproduce it?

When you remove all usb drivers etc... and let it re-detect on start up, the New Hardware is in the upper left corner instead of being centered.

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#30
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

Your "final" is actually 160 bytes smaller than two days ago and looks great! Well done. :thumbup

Thanks :)

I found New Hardware box is not centered, but is in the upper left corner. Other than that, its eligible for the SP. Thanks. I have tried the original version 4.90.3001 and did not find this bug. I have also tested another modded version and get the same results. The bug lies in version 4.90.3001 somewhere within the mod.

When you remove all usb drivers etc... and let it re-detect on start up, the New Hardware is in the upper left corner instead of being centered.

Strange.. I didn't touch any of the other dialogs. :unsure:
I will look into this, don't know whether I will have any results tonight though, I have some important things to do early in the morning.

Stay tuned! :lol:


EDIT:
Examined the 98SE, ME, and my "Final" versions in Open Watcom and eXeScope. No differences are apparent in the affected dialog between the three versions, and the "Test" mode for each file in both programs displays the dialog properly in the center of the screen. :}

The "Center" attribute is set for the dialog already in both programs. Disabling and reenabling it with Open Watcom results in a binary-identical file as the "Final" version and the same bug. Disabling and reenabling it with eXeScope results in a file with 2 bytes different from "Final" but a worse bugged dialog with the icon missing. :wacko: :wacko:


@PROBLEMCHYLD
I assume that the special version I sent you has this bug as well?

If that's the case then this bug is caused by changes back in my 1st or 3rd version and has been carried over to the later versions. No idea what is causing it, but I'm going to start completely over tomorrow using Open Watcom for all changes rather than eXeScope.

Edited by LoneCrusader, 07 November 2012 - 01:50 AM.


#31
Drugwash

Drugwash

    MSFN Expert

  • Member
  • PipPipPipPipPipPip
  • 1,259 posts
  • Joined 21-June 06
  • OS:98SE
  • Country: Country Flag

I'm going to start completely over tomorrow using Open Watcom for all changes rather than eXeScope.

That may be a waste of time. I've edited the original 4.90.3001 file from NUSB 3.6 directly in Open Watcom without any interference from other editor and the bug is there.
From my point of view, there may be a bug in Open Watcom that inadvertently clears the Center flag.
I'm currently testing Open Watcom 1.9 and all the earlier ones. The files posted by loblo pertain to some 1.3 version, although the file sizes don't quite match the ones in the archives I've just downloaded (possibly privately compiled from sources).

#32
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag
@ Drugwash and LoneCrusader, yes. The bug is there only after the file has been modded. Its not present in the original file.

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#33
loblo

loblo

    Oldbie

  • Member
  • PipPipPipPipPip
  • 763 posts
  • Joined 12-January 10
  • OS:ME
  • Country: Country Flag

The files posted by loblo pertain to some 1.3 version, although the file sizes don't quite match the ones in the archives I've just downloaded (possibly privately compiled from sources).

The files I posted came from the small package linked below, minus the unneeded files plus a missing one and all additionally UPXed by me. I should have realized they were much older, sorry about that.

http://openwatcom.mi.../cm_ide_win.zip

Edited by loblo, 07 November 2012 - 09:52 AM.


#34
Drugwash

Drugwash

    MSFN Expert

  • Member
  • PipPipPipPipPipPip
  • 1,259 posts
  • Joined 21-June 06
  • OS:98SE
  • Country: Country Flag
That explains it. I've walked around those zips as they were just too many for my taste, but I've downloaded all the installers (.exe) and extracted the same set of files from each and every version, from 1.0 to 1.9. That's why the file sizes didn't match, as you compressed them afterwards.

Strange thing is that the Center flag appears as set in VC6, ExeScope and OpenWatcom 1.9, for the 501 dialog (New Hardware Found).
Just to make sure: PROBLEMCHYLD, could you please post a screenshot of the dialog you say it's top-left aligned instead of centered? Maybe we're looking in the wrong place.

EDIT:
OK, we're wasting time. As I suspected and already mentioned somewhere above, OpenWatcom cannot deal with CPL files correctly. One may fool it into thinking a .cpl is a .dll by changing extension, but internally .cpl files are structured differently and an editor that cannot recognize a certain structure will most likely destroy it.

As a test, I've loaded with ExeScope a .cpl renamed into a .dll. Looking at dialog 10009 (for example) I noticed 5 Static, 2 RadioButton and 1 PushButton.
Then I renamed the file back to its original .cpl extension. Loading it in ExeScope revealed dialog 10009 actually has another 3 SysListView controls that didn't show up in the list previously.

I noticed this issue of missing control types much earlier but blamed it on a possibly incomplete installation of OpenWatcom. However, now I unpacked the whole contents of the binnt folder such that no possible dependency would miss and the issue is still there.

Therefore, as a conclusion I would say editing Control Panel Extension files (.cpl) in OpenWatcom using the extension change trick, is bad and will damage the internal structure. The wrong start position of a dialog is just a minor example of what can happen if we continue to do it. We need another tool, a stable and reliable one, other than Visual Studio and ExeScope, neither of which can perform the full job without errors or shortcomings.

Edited by Drugwash, 07 November 2012 - 11:01 AM.


#35
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag

That explains it. I've walked around those zips as they were just too many for my taste, but I've downloaded all the installers (.exe) and extracted the same set of files from each and every version, from 1.0 to 1.9. That's why the file sizes didn't match, as you compressed them afterwards.

Strange thing is that the Center flag appears as set in VC6, ExeScope and OpenWatcom 1.9, for the 501 dialog (New Hardware Found).
Just to make sure: PROBLEMCHYLD, could you please post a screenshot of the dialog you say it's top-left aligned instead of centered? Maybe we're looking in the wrong place.


Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#36
Drugwash

Drugwash

    MSFN Expert

  • Member
  • PipPipPipPipPipPip
  • 1,259 posts
  • Joined 21-June 06
  • OS:98SE
  • Country: Country Flag
OK, that's dialog 501 alright.
Please read my edited post above.

#37
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

That may be a waste of time. I've edited the original 4.90.3001 file from NUSB 3.6 directly in Open Watcom without any interference from other editor and the bug is there.
From my point of view, there may be a bug in Open Watcom that inadvertently clears the Center flag.
I'm currently testing Open Watcom 1.9 and all the earlier ones. The files posted by loblo pertain to some 1.3 version, although the file sizes don't quite match the ones in the archives I've just downloaded (possibly privately compiled from sources).


@ Drugwash and LoneCrusader, yes. The bug is there only after the file has been modded. Its not present in the original file.


I have checked my original "version 01" that was done with eXeScope and contained only modifications to the System/General tab (Dialog 503).
It does NOT have the bug. :blink:

Since this is the case, and the special version I sent to PROBLEMCHYLD DOES have the bug, then it must have been caused by the String edits.
(special version is v01 mods {general tab} + v03 mods {strings} without v02 mods {sys restore disk slider})

I'm still investigating.


@PROBLEMCHYLD
Could you check something else for me?
In the screenshot you posted, I see an Intel USB controller is being reinstalled.
I have the exact same controller on the VM I'm testing with.
When that particular device is reinstalled, does it show a normal USB Icon in the Device Manager when using the ME SYSDM.CPL?

I'm seeing a different Icon for it when using the ME version than the normal USB Icon I see with the 98SE version...


@dencorso
I didn't expect this issue to be so involved or require so much work. I don't want to hijack this thread, so it may be best to split my original SYSDM.CPL post (#732) and the rest of this off into a new thread, say, "Modified SYSDM.CPL 4.90.3001 for 98SE"?

Edited by LoneCrusader, 07 November 2012 - 04:54 PM.


#38
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag

@PROBLEMCHYLD

Could you check something else for me?
In the screenshot you posted, I see an Intel USB controller is being reinstalled.
I have the exact same controller on the VM I'm testing with.
When that particular device is reinstalled, does it show a normal USB Icon in the Device Manager when using the ME SYSDM.CPL?

I'm seeing a different Icon for it when using the ME version than the normal USB Icon I see with the 98SE version...

Yes the icons are different. But it only does it on my USB 2.0 device. All others have original icons. I was going to report this too, but one problem at a time. Thanks

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#39
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

Yes the icons are different. But it only does it on my USB 2.0 device. All others have original icons. I was going to report this too, but one problem at a time. Thanks

Bizarre. Neither the original USB Icon nor the Icon I'm seeing are present in SYSDM.CPL at all.

I agree one problem at a time, but I went ahead and mentioned it because whatever is causing it is already in the official ME version and is not caused by a mod...

#40
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag

whatever is causing it is already in the official ME version and is not caused by a mod...

Yes, you are correct :}

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#41
Drugwash

Drugwash

    MSFN Expert

  • Member
  • PipPipPipPipPipPip
  • 1,259 posts
  • Joined 21-June 06
  • OS:98SE
  • Country: Country Flag
Question is: where does version 4.90.3001 in NUSB 3.6 come from? Is it a MS official update/QFE/etc or is it the default 4.90.3000 from the CD and has been hacked by someone else prior to adding it to NUSB? The answer to this question may explain the abnormal icons you're seeing and possibly other issues yet to surface. I mean, if the file has been modified using a tool that breaks the structures just as OpenWatcom does, we'd be better off using the official 4.90.3000 in our modding attempts, considering the changes that have been made previously (if any) that made it into 4.90.3001.
At this point, only Maximus-Decim may be able to provide the answer, unless someone else can prove the origin of the 4.90.3001 file.

I also agree to splitting the discussion pertaining to sysdm.cpl modding, to a separate thread.

#42
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag

Question is: where does version 4.90.3001 in NUSB 3.6 come from? Is it a MS official update/QFE/etc or is it the default 4.90.3000 from the CD and has been hacked by someone else prior to adding it to NUSB? The answer to this question may explain the abnormal icons you're seeing and possibly other issues yet to surface. I mean, if the file has been modified using a tool that breaks the structures just as OpenWatcom does, we'd be better off using the official 4.90.3000 in our modding attempts, considering the changes that have been made previously (if any) that made it into 4.90.3001.
At this point, only Maximus-Decim may be able to provide the answer, unless someone else can prove the origin of the 4.90.3001 file.

I also agree to splitting the discussion pertaining to sysdm.cpl modding, to a separate thread.

http://support.microsoft.com/?id=272620 No mods or secrets, Its official. I already checked CRC/Hashes etc.... You can find it on MDGx site.

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#43
Drugwash

Drugwash

    MSFN Expert

  • Member
  • PipPipPipPipPipPip
  • 1,259 posts
  • Joined 21-June 06
  • OS:98SE
  • Country: Country Flag
Good, we cleared this up. Another question: does the abnormal icon (screenshot, anyone?) show with the CD version of sysdm.cpl 4.90.3000? I'm trying to find out if this is a default mismatch between ME and 98SE or if it's been introduced with the updated 3001 version. We should be able to analyse the two versions and hopefully pinpoint and fix the issue, if it turns out 3000 works OK compared to 3001. Otherwise it will be a little harder to find out why it's happening.

#44
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag

Good, we cleared this up. Another question: does the abnormal icon (screenshot, anyone?) show with the CD version of sysdm.cpl 4.90.3000? I'm trying to find out if this is a default mismatch between ME and 98SE or if it's been introduced with the updated 3001 version. We should be able to analyse the two versions and hopefully pinpoint and fix the issue, if it turns out 3000 works OK compared to 3001. Otherwise it will be a little harder to find out why it's happening.

No, it lies inside (ANY) version of SYSDM.CPL from Windows ME. This was the reason I didn't update this specific file when Maximus-Decim updated his/her package. Yes, its faster and you don't need to click next to install USB drivers. Everything is automated.

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#45
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

Question is: where does version 4.90.3001 in NUSB 3.6 come from? Is it a MS official update/QFE/etc or is it the default 4.90.3000 from the CD and has been hacked by someone else prior to adding it to NUSB?

http://support.microsoft.com/?id=272620 No mods or secrets, Its official. I already checked CRC/Hashes etc.... You can find it on MDGx site.

All of my modifications were done on the original file extracted from the ME HotFix rather than the one extracted from NUSB, although I'm sure they're identical.

(screenshot, anyone?)

Posted Image

#46
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

I've retested my previous v01, v02, and v03 files. They do NOT have the "not centered" bug on my system. :blink:

I'm reposting a link to my v03. Please retest and see if you all are still getting the "New Hardware not centered" bug...

EDIT:
V03 link removed.

Edited by LoneCrusader, 11 November 2012 - 03:19 PM.


#47
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

I've retested my previous v01, v02, and v03 files. They do NOT have the "not centered" bug on my system. :blink:

I'm reposting a link to my v03. Please retest and see if you all are still getting the "New Hardware not centered" bug...

What, no testers? :o

Maybe I should just not post the new, final, fixed version? :whistle:

Edited by LoneCrusader, 11 November 2012 - 03:19 PM.


#48
Drugwash

Drugwash

    MSFN Expert

  • Member
  • PipPipPipPipPipPip
  • 1,259 posts
  • Joined 21-June 06
  • OS:98SE
  • Country: Country Flag
So, did you find out why the wrong icon in Device Manager and why dialogs are not centered? Personally I've had a weird day, can't figure out how I wasted it but somehow managed not to do anything useful. :(

Only thing I found out is that the wrong icon pertains to a Tape device which somehow gets installed by the ME CPL and is found in pnpwprop.dll. Wasn't able to write a single line of code for the CPL reader/editor I intend to build. :(

(ah, these typos...)

Edited by Drugwash, 08 November 2012 - 05:48 PM.


#49
PROBLEMCHYLD

PROBLEMCHYLD

    The Resurrector for old Windows OS

  • Member
  • PipPipPipPipPipPipPipPip
  • 2,531 posts
  • Joined 07-October 05
  • OS:98SE
  • Country: Country Flag


I've retested my previous v01, v02, and v03 files. They do NOT have the "not centered" bug on my system. :blink:

I'm reposting a link to my v03. Please retest and see if you all are still getting the "New Hardware not centered" bug...

SYSDMCPL.ZIP - V03 - 156.9 Kb

What, no testers? :o

Maybe I should just not post the new, final, fixed version? :whistle:

My system is installing SP3.10 right now. I will have a screenshot for you soon. Also V3 does NOT have the center bug :w00t:

Believe God is the Alpha and Omega.
Believe Jesus Christ died for our sins.
Repent for your sins now or there will be
BLOOD

The Path to God


U98SESP3 03-11-2013


#50
LoneCrusader

LoneCrusader

    Resistere pro causa resistentiam.

  • MSFN Sponsor
  • 819 posts
  • Joined 11-May 09
  • OS:98SE
  • Country: Country Flag

Donator

So, did you find out why the wrong icon in Device Manager and why dialogs are not centered? Personally I've had a weird day, can't figure out how I wasted it but somehow managed not to do anything useful. :(

Only thing I found out is that the wrong icon pertains to a Tape device which somehow gets installed by the ME CPL and is found in pnpwprop.dll. Wasn't able to write a single line of code for the CPL reader/editor I intend to build. :(

(ah, these typos...)

My system is installing SP3.10 right now. I will have a screenshot for you soon. Also V3 does NOT have the center bug :w00t:

No, I didn't find the source of the icon problem. :no: But, as it affects all ME versions and is not caused by a Mod, I figure we will address it as a new project, but still within the scope of this discussion and thread.

I have however, after much trial and error, managed to get all of the ME specific items removed and strings fixed. :w00t:


(The story...)
I discovered that my original versions 1-3 modified with eXeScope did not suffer from the "New Hardware not centered" bug. It was only with version 4, when I started using Open Watcom, that the bug appeared.

I opened the original ME HotFix file with Open Watcom and saved it without making ANY changes. Then I compared the original and the saved version with a Hex Editor. Open Watcom added 32 sequential bytes of rubbish, nothing but NULL characters, into the file and changed 222 other bytes (increased all by 2 dec.) that I assume are some type of data "offsets" or "addresses" for the rest of the file. The file now had the "not centered" bug.

I took my v03 and modified ONE single item with Open Watcom (unchecked "Visible" for the "Disable System Restore" option) and saved it. Then I compared that file against my v03 with a Hex Editor. Open Watcom had added 16 bytes of rubbish this time, along with the "offset" changes, but I was able to figure out which 2 bytes had been changed that were important.

I returned to my v03, and used the Hex Editor to change ONLY those two bytes. This file worked properly, with the "Disable" option hidden, and no "not centered" bug.

I repeated this process, changing things with Open Watcom; comparing the changes against the file modified directly with a Hex Editor; figuring out what bytes were relevant; and then applying them to the Hex Edited file.

It took a while, but I now have all of the ME options hidden, all of the ME strings changed to 98, and no errors caused by modding that I am aware of.

This file should be tested thoroughly as well though.

SYSDMCPL.ZIP - V06

Edited by LoneCrusader, 14 April 2013 - 08:34 PM.





0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users