[Drugwash]

Easy, don't get a heart attack!
I've considered users' wish to keep everything in its original form. If I put this out, it will be in two versions: one containing original resources (icons, bitmaps, avi etc) and one containing updated resources, for those who want modern look, possibly for use in conjunction with Revolutions Pack's themes.

[LoneCrusader]

Drugwash, on 06 November 2012 - 10:28 AM, said:

Easy, don't get a heart attack!
I've considered users' wish to keep everything in its original form. If I put this out, it will be in two versions: one containing original resources (icons, bitmaps, avi etc) and one containing updated resources, for those who want modern look, possibly for use in conjunction with Revolutions Pack's themes.

Ok, that's cool.

I fully support "personalization" but I prefer it be left up to each user. Some Icons I update on my own 98SE, some I don't, etc etc.

As long as there is a "bare minimum" modification version in existence before other changes are made, I'm happy.

[PROBLEMCHYLD]

We have 3 members working hard on this somewhat hybrid file. What version should I use and from whom?

[LoneCrusader]

PROBLEMCHYLD, on 06 November 2012 - 12:20 PM, said:

We have 3 members working hard on this somewhat hybrid file. What version should I use and from whom?

My original linked version in my first post about SYSDM.CPL (timestamped 3:00:00 AM, it was my own internal 3rd version) has all of the modifications to make the file correct for 98SE with ONE exception - the "Disable System Restore" option is still present on the Troubleshooting dialog.

ONLY the bare minimum of modifications required to make the file correct for 98SE were made; I didn't even increase the version number (will leave that for when this is finalized.)

My goal is to get that one thing hidden, with the minimum amount of changes possible, and I will consider it to be "final." Any other modifications would be up to users.


{offtopic}
IIRC, PROBLEMCHYLD, you use a backported version of ME's System Restore on your own 98SE don't you?

If you like I will take one of my older builds and only modify the System/General Tab and the Strings so that you can have & use the System Restore controls on your own system.
{/offtopic}

[PROBLEMCHYLD]

LoneCrusader, on 06 November 2012 - 02:06 PM, said:

ONLY the bare minimum of modifications required to make the file correct for 98SE were made; I didn't even increase the version number (will leave that for when this is finalized.)

This will be the version I add to SP3.x once everything is finalized

LoneCrusader, on 06 November 2012 - 02:06 PM, said:

{offtopic}
IIRC, PROBLEMCHYLD, you use a backported version of ME's System Restore on your own 98SE don't you?

If you like I will take one of my older builds and only modify the System/General Tab and the Strings so that you can have & use the System Restore controls on your own system.
{/offtopic}

I'm not using it at the moment, but I will be once I kill all the bugs in SP3

[LoneCrusader]

I'm working on the final version right now.

Thanks loblo, Open Watcom seems to do the trick with SYSDM.CPL renamed to .DLL

I will edit this post with a link to the "Final" version for testing as soon as I'm done.


EDIT:
Here's a link to the Final version.
{Old link to Bugged File Removed}

File version number has been increased to 4.90.3002, but note that this file is customized for 98SE ONLY.
Do NOT use with Windows ME. It contains nothing useful for Windows ME and has ME-specific items removed.

All changes to this file have been cosmetic, but it should be tested in various situations, such as: removing and installing devices/drivers, and enabling/disabling items on the various "File System" dialogs to be sure there are no unseen side effects.

Report any and all bugs here.

This post has been edited by LoneCrusader: 08 November 2012 - 11:54 PM

[PROBLEMCHYLD]

I found New Hardware box is not centered, but is in the upper left corner. Other than that, its eligible for the SP. Thanks. I have tried the original version 4.90.3001 and did not find this bug. I have also tested another modded version and get the same results. The bug lies in version 4.90.3001 somewhere within the mod.

This post has been edited by PROBLEMCHYLD: 06 November 2012 - 06:37 PM

[jumper]

Open Watcom looks like the winner!

I produced a "final" at about the same time this afternoon using VC6. It's functionally identical to yours, but I was unhappy with the 19KB of bloat VC6 added.

Your "final" is actually 160 bytes smaller than two days ago and looks great! Well done.

@PC: I count 14 dialogs with "New Hardware" in the caption. Which are you referring to and how can we reproduce it?

[PROBLEMCHYLD]

jumper, on 06 November 2012 - 07:15 PM, said:

Open Watcom looks like the winner!

I produced a "final" at about the same time this afternoon using VC6. It's functionally identical to yours, but I was unhappy with the 19KB of bloat VC6 added.

Your "final" is actually 160 bytes smaller than two days ago and looks great! Well done.

@PC: I count 14 dialogs with "New Hardware" in the caption. Which are you referring to and how can we reproduce it?

When you remove all usb drivers etc... and let it re-detect on start up, the New Hardware is in the upper left corner instead of being centered.

[LoneCrusader]

jumper, on 06 November 2012 - 07:15 PM, said:

Your "final" is actually 160 bytes smaller than two days ago and looks great! Well done.

Thanks

PROBLEMCHYLD, on 06 November 2012 - 06:24 PM, said:

I found New Hardware box is not centered, but is in the upper left corner. Other than that, its eligible for the SP. Thanks. I have tried the original version 4.90.3001 and did not find this bug. I have also tested another modded version and get the same results. The bug lies in version 4.90.3001 somewhere within the mod.

PROBLEMCHYLD, on 06 November 2012 - 07:30 PM, said:

When you remove all usb drivers etc... and let it re-detect on start up, the New Hardware is in the upper left corner instead of being centered.

Strange.. I didn't touch any of the other dialogs.
I will look into this, don't know whether I will have any results tonight though, I have some important things to do early in the morning.

Stay tuned!


EDIT:
Examined the 98SE, ME, and my "Final" versions in Open Watcom and eXeScope. No differences are apparent in the affected dialog between the three versions, and the "Test" mode for each file in both programs displays the dialog properly in the center of the screen.

The "Center" attribute is set for the dialog already in both programs. Disabling and reenabling it with Open Watcom results in a binary-identical file as the "Final" version and the same bug. Disabling and reenabling it with eXeScope results in a file with 2 bytes different from "Final" but a worse bugged dialog with the icon missing.


@PROBLEMCHYLD
I assume that the special version I sent you has this bug as well?

If that's the case then this bug is caused by changes back in my 1st or 3rd version and has been carried over to the later versions. No idea what is causing it, but I'm going to start completely over tomorrow using Open Watcom for all changes rather than eXeScope.

This post has been edited by LoneCrusader: 07 November 2012 - 01:50 AM

[Drugwash]

Quote

I'm going to start completely over tomorrow using Open Watcom for all changes rather than eXeScope.

That may be a waste of time. I've edited the original 4.90.3001 file from NUSB 3.6 directly in Open Watcom without any interference from other editor and the bug is there.
From my point of view, there may be a bug in Open Watcom that inadvertently clears the Center flag.
I'm currently testing Open Watcom 1.9 and all the earlier ones. The files posted by loblo pertain to some 1.3 version, although the file sizes don't quite match the ones in the archives I've just downloaded (possibly privately compiled from sources).

[PROBLEMCHYLD]

@ Drugwash and LoneCrusader, yes. The bug is there only after the file has been modded. Its not present in the original file.

[loblo]

Drugwash, on 07 November 2012 - 08:20 AM, said:

The files posted by loblo pertain to some 1.3 version, although the file sizes don't quite match the ones in the archives I've just downloaded (possibly privately compiled from sources).

The files I posted came from the small package linked below, minus the unneeded files plus a missing one and all additionally UPXed by me. I should have realized they were much older, sorry about that.

http://openwatcom.mi.../cm_ide_win.zip

This post has been edited by loblo: 07 November 2012 - 09:52 AM

[Drugwash]

That explains it. I've walked around those zips as they were just too many for my taste, but I've downloaded all the installers (.exe) and extracted the same set of files from each and every version, from 1.0 to 1.9. That's why the file sizes didn't match, as you compressed them afterwards.

Strange thing is that the Center flag appears as set in VC6, ExeScope and OpenWatcom 1.9, for the 501 dialog (New Hardware Found).
Just to make sure: PROBLEMCHYLD, could you please post a screenshot of the dialog you say it's top-left aligned instead of centered? Maybe we're looking in the wrong place.

EDIT:
OK, we're wasting time. As I suspected and already mentioned somewhere above, OpenWatcom cannot deal with CPL files correctly. One may fool it into thinking a .cpl is a .dll by changing extension, but internally .cpl files are structured differently and an editor that cannot recognize a certain structure will most likely destroy it.

As a test, I've loaded with ExeScope a .cpl renamed into a .dll. Looking at dialog 10009 (for example) I noticed 5 Static, 2 RadioButton and 1 PushButton.
Then I renamed the file back to its original .cpl extension. Loading it in ExeScope revealed dialog 10009 actually has another 3 SysListView controls that didn't show up in the list previously.

I noticed this issue of missing control types much earlier but blamed it on a possibly incomplete installation of OpenWatcom. However, now I unpacked the whole contents of the binnt folder such that no possible dependency would miss and the issue is still there.

Therefore, as a conclusion I would say editing Control Panel Extension files (.cpl) in OpenWatcom using the extension change trick, is bad and will damage the internal structure. The wrong start position of a dialog is just a minor example of what can happen if we continue to do it. We need another tool, a stable and reliable one, other than Visual Studio and ExeScope, neither of which can perform the full job without errors or shortcomings.

This post has been edited by Drugwash: 07 November 2012 - 11:01 AM

[PROBLEMCHYLD]

Drugwash, on 07 November 2012 - 10:03 AM, said:

That explains it. I've walked around those zips as they were just too many for my taste, but I've downloaded all the installers (.exe) and extracted the same set of files from each and every version, from 1.0 to 1.9. That's why the file sizes didn't match, as you compressed them afterwards.

Strange thing is that the Center flag appears as set in VC6, ExeScope and OpenWatcom 1.9, for the 501 dialog (New Hardware Found).
Just to make sure: PROBLEMCHYLD, could you please post a screenshot of the dialog you say it's top-left aligned instead of centered? Maybe we're looking in the wrong place.

[Drugwash]

OK, that's dialog 501 alright.
Please read my edited post above.

[LoneCrusader]

Drugwash, on 07 November 2012 - 08:20 AM, said:

That may be a waste of time. I've edited the original 4.90.3001 file from NUSB 3.6 directly in Open Watcom without any interference from other editor and the bug is there.
From my point of view, there may be a bug in Open Watcom that inadvertently clears the Center flag.
I'm currently testing Open Watcom 1.9 and all the earlier ones. The files posted by loblo pertain to some 1.3 version, although the file sizes don't quite match the ones in the archives I've just downloaded (possibly privately compiled from sources).

PROBLEMCHYLD, on 07 November 2012 - 09:32 AM, said:

@ Drugwash and LoneCrusader, yes. The bug is there only after the file has been modded. Its not present in the original file.

I have checked my original "version 01" that was done with eXeScope and contained only modifications to the System/General tab (Dialog 503).
It does NOT have the bug.

Since this is the case, and the special version I sent to PROBLEMCHYLD DOES have the bug, then it must have been caused by the String edits.
(special version is v01 mods {general tab} + v03 mods {strings} without v02 mods {sys restore disk slider})

I'm still investigating.


@PROBLEMCHYLD
Could you check something else for me?
In the screenshot you posted, I see an Intel USB controller is being reinstalled.
I have the exact same controller on the VM I'm testing with.
When that particular device is reinstalled, does it show a normal USB Icon in the Device Manager when using the ME SYSDM.CPL?

I'm seeing a different Icon for it when using the ME version than the normal USB Icon I see with the 98SE version...


@dencorso
I didn't expect this issue to be so involved or require so much work. I don't want to hijack this thread, so it may be best to split my original SYSDM.CPL post (#732) and the rest of this off into a new thread, say, "Modified SYSDM.CPL 4.90.3001 for 98SE"?

This post has been edited by LoneCrusader: 07 November 2012 - 04:54 PM

[PROBLEMCHYLD]

LoneCrusader, on 07 November 2012 - 04:40 PM, said:

@PROBLEMCHYLD

Could you check something else for me?
In the screenshot you posted, I see an Intel USB controller is being reinstalled.
I have the exact same controller on the VM I'm testing with.
When that particular device is reinstalled, does it show a normal USB Icon in the Device Manager when using the ME SYSDM.CPL?

I'm seeing a different Icon for it when using the ME version than the normal USB Icon I see with the 98SE version...

Yes the icons are different. But it only does it on my USB 2.0 device. All others have original icons. I was going to report this too, but one problem at a time. Thanks

[LoneCrusader]

PROBLEMCHYLD, on 07 November 2012 - 05:04 PM, said:

Yes the icons are different. But it only does it on my USB 2.0 device. All others have original icons. I was going to report this too, but one problem at a time. Thanks

Bizarre. Neither the original USB Icon nor the Icon I'm seeing are present in SYSDM.CPL at all.

I agree one problem at a time, but I went ahead and mentioned it because whatever is causing it is already in the official ME version and is not caused by a mod...

[PROBLEMCHYLD]

LoneCrusader, on 07 November 2012 - 05:08 PM, said:

whatever is causing it is already in the official ME version and is not caused by a mod...

Yes, you are correct