Pachilles Posted November 14, 2012 Share Posted November 14, 2012 A simple renaming of files becomes a serious headache, and I'm not sure why it's getting so complicated.Folder: C:\My FilesExample list of files:Mr. Apple.removethis.txtMy.apples.are.rotten.removethis.txtThisAppleIsBad.removethis.docI Like Apple Pie because apples are great.(Awesome even).removethis.pdf...Obviously (by my examples), I want to remove .removethis from all of the file names.Simple, right?RENAME (like most DOS) gets confused with spaces in files and folders.RENAME gets lost with the use of periods.I can usually work around these issues, but for some reason everything I try causes different things to happen to different files, and every work-around I come up with falls flat somewhere.I won't even try listing them, except my latest attempt.BTW... I've manipulated where my quotes are... pretty much everywhere, and this is my best result.I just know that I'm missing something really simple... but this whole mission was supposed to be simple.BAT:for %%i in (*.txt) do (set MyFile=%%irename "%MyFile%" "%MyFile:~0, -11%.txt")Results in:C:\My Files>z-MyBatchFile.batC:\My Files>for %i in (*.txt) do (set MyFile=%i rename "" "~0, -11.txt")C:\My Files>(set MyFile=Mr. Apple.removethis.txt rename "" "~0, -11.txt")The system cannot find the file specified.C:\My Files>(set MyFile=My.apples.are.rotten.removethis.txt rename "" "~0, -11.txt")The system cannot find the file specified.C:\My Files> Link to comment Share on other sites More sharing options...
Guest Posted November 14, 2012 Share Posted November 14, 2012 (edited) The extra space in %MyFile:~0, -11% is breaking the expression. Don't use a space after the comma.Scratch that. "SETLOCAL EnableDelayedExpansion" is needed.The following code should work. Notice the use of exclamation marks in place of some percent signs. And 11 becomes 15 to offset the file extension.SETLOCAL EnableDelayedExpansionfor %%i in (*.txt) do (set MyFile=%%irename "!MyFile!" "!MyFile:~0, -15!.txt")This should also work, and doesn't require changing 11 to 15.SETLOCAL EnableDelayedExpansionfor %%I in (*.txt) do (set MyFile=%%~nIrename "%%I" "!MyFile:~0, -11!%%~xI")And this too, but will remove all instances of the text to remove regardless of where in the file name they're located.SETLOCAL EnableDelayedExpansionfor %%i in (*.txt) do (set MyFile=%%iset Myfile=!MyFile:.removethis=!rename "%%i" "!MyFile!") Edited November 14, 2012 by 5eraph Link to comment Share on other sites More sharing options...
Pachilles Posted November 14, 2012 Author Share Posted November 14, 2012 (edited) OMG OMG!Life saver!I'm sooo pleased!So, this should work for all types of files (last code suggestion: changing *.txt to *.*)?SETLOCAL EnableDelayedExpansionfor %%i in (*.*) do (set MyFile=%%iset Myfile=!MyFile:.removethis=!rename "%%i" "!MyFile!")Oh, and having .removethis, actually being .remove.this won't mess with it (having an additional period)?Testing... testing... excited testing...This would solve ALL of my renaming issues!Tested and works! YES!I bow to the master!<later>Ok, calm now. 35k+ files with the unwanted text... easy fix, never the problem.Managing the constant flow of new files with the offending text? Big Pain. But no longer... thanks to you. Edited November 14, 2012 by Pachilles Link to comment Share on other sites More sharing options...
Guest Posted November 14, 2012 Share Posted November 14, 2012 Glad I could help. SS64.com has more information on variable substring replacements that may interest you. Link to comment Share on other sites More sharing options...
Pachilles Posted November 14, 2012 Author Share Posted November 14, 2012 Nice! Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now