This post has been edited by WildBill: 11 February 2007 - 02:12 AM
Posted 11 February 2007 - 02:12 AM
Posted 11 February 2007 - 04:55 AM
Another thing was that neither the tray icons nor the clock were visible; they were all covered by the skin (I use a WB skin), but the tray icons section was flickering when getting updated or hovered with the mouse.
One other thing I noticed is that the Start button caption wouldn't change to what was set in the preferences. After I tried to change and apply a few combinations, explorer crashed (short report below).
However, the whole taskbar was completely skinned, which never happened with older versions of TClock2 or TClock Light Unofficial (dunno if it was supposed to happen with those, though). That's great.
So - all in all - things are going the right way; you're doing a great job!
EXPLORER caused an invalid page fault in module TCLOCK3.DLL at 0187:014d1e83. Registers: EAX=015dfff0 CS=0187 EIP=014d1e83 EFLGS=00010206 EBX=015b3610 SS=018f ESP=0080f098 EBP=0080f0c4 ECX=00000000 DS=018f ESI=0002c9ec FS=252f EDX=0002c9ec ES=018f EDI=015b3610 GS=0000 Bytes at CS:EIP: 89 70 08 81 fe 00 10 00 00 7f 37 8b d6 85 d2 79 Stack dump: 015dfffc 015b3610 0002c9ec 014d2449 0080f0d4 014d2472 0080f0c4 015debfc 015b3610 0002b5ec 00000000 0080f0f0 014d1ced 014d1f33 014d23e5 0080f100
Posted 11 February 2007 - 08:09 AM
• A "ghost" taskbar button flickers when hovering folders in the Start menu (Programs, Documents, custom ones, etc).
• The start menu tries to get skinned, but all it happens is it gets black, with only icons visible - no text (black on black, possibly). That is not because of transparency, it wasn't enabled. Showing menus and submenus is painfully slow.
• Rebar arrows are not being painted.
• Clock tooltip doesn't show anymore (probably because of some skinning settings or because it's set to multiline).
• The whole desktop refresh is much more slower now when TClock3 has enabled icon label transparency and text shadows. However, machine specs are low - 800MHz CPU, 240MB RAM, 16MB video onboard (SiS630 chipset).
• Still unstable - explorer crashed again after changing a few settings. The options panel remained visible and functional, however no settings were being applied anymore. The TClock process remains in the memory and needs to be killed, as there's no other possibility to close it gracefully. After disabling Start Menu skinning, there was no more crash, and I made sure to play with settings a lot, so that must be the source of crashes.
• All in all, it's quite a memory hog - I couldn't even open MSPaint at one point, so I had to exit TClock3. One cause may be the cache, which was enabled.
Here's a screenshot of what I've been able to achieve so far:
Posted 11 February 2007 - 01:13 PM
WindowBlinds skins don't normally come with rebar or start menu arrows, so I made some of my own and they come with TClock3. They use MagicPink transparency if you decide to use them.
I'm seeing the black-on-black problem as well, both on the start menu and on the taskbar buttons. It appears to be a problem with the subpixel anti-aliasing code and Win98. When I turn it off they draw properly and a lot faster. I haven't seen the ghost taskbar button yet or the memory usage. Is there a way to get a proper task manager in Win98? I've been using Win2k since 2001 so I'm not really familiar with Win98 anymore.
The problem with TClock3 still hanging around when Explorer crashes is a known problem. One of these days I need to get it to exit when that happens but to date is just hasn't been a high priority.
I have a lot of other things that I have to do today so I can't guarantee much but I'll try to learn what I can.
One other thing: you should turn the cache setting off. I had it disabled in the code since it was causing all kinds of instability issues in Win2k as well. I don't know if it's related to memory usage or to something else. I saw on the Win98 forum that there is another program that does some pretty incredible Win98 skinning, with "native skinning". I don't know if that technique would help me or not, but if someone could explain to me what is meant by native skinning I'd appreciate it.
This post has been edited by WildBill: 11 February 2007 - 01:21 PM
Posted 11 February 2007 - 05:33 PM
• I reported the rebar arrows issue precisely because I tried with one of yours (the white one) and it didn't show up under any circumstances.
• Subpixel antialiasing is (and always was) disabled here.
• The ghost task button appears only for a split second and is probably noticeable only on slow machines. It can be seen better when there are one or two task buttons on taskbar and the start menu folders are hovered continuously up and down (I have 10 custom folders in the start menu, including a cascaded Control Panel).
• For advanced task managing you could try CodeStuff Starter (freeware). FreeRAM XP Pro (freeware) can also monitor CPU, User and System resources in a simple way (can be seen in screenshot).
• I'm not sure what you're referring to by "native skinning", but in case it's about Tihiy's Revolutions Pack, maybe you could talk to him directly, it'd be much easier to exchange impressions and ideas.
Now to the news. Measurement of System | User | GDI resources (using FreeRAM XP Pro):
- 90 90 94 at startup
- 86 86 92 after ScreenGrab started
- 84 84 92 after Metapad started
- 53 53 79 after TClock3 started
- 25 25 79 after Explorer crashed
- 81 81 89 after killing TClock3 process
After more testing, the following problems were found:
• Task buttons are not properly resized when taskbar is moved from horizontal to vertical position and back (a few times).
• Clock tooltip will not show year unless it's using capital Ys (could be so by design).
• Left mouse clicks on clock are not detected; only right-click, opens the context menu.
• Tray/Clock Fill -> Fill Style shows clock only when set to "Fill tray" or "Skin tray"; other modes hide/cover the clock.
• After half an hour of enabling start menu skinning and tweaking settings: resources are 25 25 72. Just hovering the start menu and submenus a few times: 20 20 70. Cache is disabled. This may be a sign of GDI/resources leak.
• A very weird bug with a 2px horizontal line at the bottom of the start button is being drawn (modified) by the CPU and LOAD progressbars in FreeRAM XP Pro 1.52 when its window is open on desktop (see screenshot).
More weird is that the said line wouldn't act up if there's a tooltip showing for any of the icons in either taskbar or any custom toolbars.
It also wouldn't show if there's ScreenGrab open (so I can't take a quick screenshot). It also appears occasionally when other windows are open or when typing in a text file; could be a video memory issue?
• Custom toolbars on the side of the screen are not completely skinned: only icon backgrounds are skinned, the header is unchanged and the rest of the toolbar is transparent. Shouldn't be, in 98SE (I think), but I replaced gdi32.dll with the ME one and that added some previously nonexistant functions, including transparency (see screenshot).
• Submenus in the start menu are not getting skinned until hovered. However, large submenus (the cascaded Control Panel with 32 items and a custom one under Programs > Uninstallers, with 35 items) do get skinned instantly when shown.
• One separator in the start menu doesn't get skinned; probably there's no entry for it (between SymmTime and Programs, top-left in the second screenshot).
• The Task Manager entry in the context menu does nothing.
• When icon text is set to transparent and an icon is selected on desktop, the text background turns dark blue. Could this color be changed, at least to the default background color set in display properties if not to a custom one?
• Hmmm... just when I thought everything was OK and tried to close TClock3, it crashed Explorer. Maybe start menu skinning is not a good idea, for now.
That's about all I can think of, right now. Gotta go to sleep. Cheers!
Posted 12 February 2007 - 02:25 AM
i thought i give u some bugs and stuff.
but i see that it has allready be done.
the most things i have also here.
but the only thing that didnt work for me is the skinning of the tray and clock and the other windows.
the taskbar works prime!
tried it first with some bmp's.
not good, switched to wb skin, and voila!
so keep up the work man.
and maybe its a good idea to ask tihiy for assistance in the matter?
Posted 12 February 2007 - 10:22 PM
I went through the Revolutions Pack thread and I'm really impressed. You're making the whole OS over I'd love to see if it can be ported to Win2k since that's all I run (except for testing specific problems that people point out). I saw that you were having problems getting it to run on Win2k -- I don't know how your software works but I wouldn't mind offering some help if I can. I use a local and/or global hook in TClock3; if you're doing something similar I can probably help at least a little since I had to deal with lots of OS issues already in getting TClock3 to run. At least maybe I can try to steer you around the pitfalls that I fell into
I also have a small alpha program in the XPize forum here called SmoothText that overrides Windows DLL behavior by using a global hook, loading the DLL that I want to override, using VirtualProtect() to allow changing the code, and altering it to point to custom routines. I don't know if you're attempting anything similar, but I've managed to make it pretty reliable on Win2k if that might help you. I don't know if Win98 can do what SmoothText does, but you surely know a lot more about 98 than I do. SmoothText tries to render *all* text in Win2k using sub-pixel aliasing (sort of a poor-man's ClearType without violating the patent). Subpixel-aliasing text was invented by Apple in 1981, so I've read, so it should be safe.
This post has been edited by WildBill: 12 February 2007 - 11:12 PM
Posted 13 February 2007 - 02:01 PM
Instead, i hack system DLLs directly
I swear now that i'll definitely make an Revolutions Pack version for 2000 too. AppInit_DLLs and VirtualProtect will help me.
As for subpixel font rendering - well, man, you rock! It is incredible, fast and stable. However, my eyes hurt - but that is minor detail
I'm really impressed that you could read that all.
Posted 14 February 2007 - 12:31 AM
I went through every file in TClock3 from top to bottom and I located the GDI leak. It was actually Win98 problem -- apparently the Windows TransparentBlt() call has a GDI leak in Win95 and Win98. Fortunately TClock3 has a replacement for Win95, so I simply told it to use that for 98 as well. I also found quite a few other GDI and memory leaks in my code, and I put try...catch blocks around everything I could find that allocates something and deallocates it later. If there are any further leaks, they should be architectural in nature (such as having a finalization routine not get rid of everything that the corresponding initialization routine creates). I tested the newest version on my Win98 box and it's performing much better. I've updated the download link at the top to point to the new version.
Posted 14 February 2007 - 11:36 AM
• Skinning is faster now and doesn't take up so many resources (at start)
• Painting glitch below the Start button is fixed
Resources (System|User|GDI) in percent:
63 63 64 initially
34 34 61 immediately after TClock3 0.2.8 startup
7 7 54 after changing and applying some settings
9 9 64 after Explorer crash and restart
All other issues reported previously are still present. There will come their time.
After changing and applying some settings and closing the options panel, a click on the Start button crashed Explorer. Most tray icons haven't been restored.
EXPLORER caused an invalid page fault in module <unknown> at 0000:00000001. Registers: EAX=00000000 CS=0187 EIP=00000001 EFLGS=00010202 EBX=0080f66c SS=018f ESP=0080f57c EBP=0080f618 ECX=019c0647 DS=018f ESI=0000c690 FS=2537 EDX=00003ade ES=018f EDI=0080f620 GS=0000 Bytes at CS:EIP: 01 00 00 00 04 70 00 c3 e2 00 f0 65 04 70 00 65 Stack dump: 019c0647 00000c44 00000002 00000000 00000000 0080f654 019c0666 0080f618 0000c690 0080f66c 1434c5b4 bff713e2 00000187 bff74272 0001cb04 0001cb04
Posted 17 February 2007 - 05:59 AM
Also, I've set double left click on the clock to show calendar, but it doesn't seem to work - I can only get to it via the context menu. Do I need to change anything for this (this was actually inherited from my old TClock2 setup, so i only just noticed it).
Posted 03 March 2007 - 02:20 AM
Posted 10 March 2007 - 10:55 AM
Is this normal behaviour on a Win98se machine?
The utility is looking good so far ... black blob clock aside that is ...
This post has been edited by soporific: 10 March 2007 - 10:56 AM
Posted 10 March 2007 - 03:43 PM
Firstly there's this very editbox (image #1). As you can see, the cursor position gradually becomes more and more displaced the further to the right of the editbox you get, making editing very difficult.
Secondly, the smoothing can have a detrimental effect on the layout in some windows - see image #2 for an example where the text on imageshack.us is no longer on a single line like it should be.
Thirdly, for some reason the Documents menu under Start doesn't render correctly for some reason if it is (empty) - see the third pic.
I'm also having some problems with the clock, though funnily enough the normal clock works fine, but customising with TClock results in part of the clock not being displayed - see image #4 for a before/after.
Lastly, smoothed text can be badly corrupted if another window containing certain elements is overlaid, e.g. my browser window looks like the last picture once I've had a multiline editbox over it.
I hope these issues can be resolved, because I'd like to use this if they can, but unfortunately the errors.
(Also hope these attach properly...)
Posted 13 March 2007 - 03:04 PM
For TClock3, you don't have to tell it not to customize the clock. Instead, set the tray to "skin tray" and tell the Clock full skinning page to use one of the quicklaunch images. You *might* also have to tell the format page to use a custom format, like "h:nn tt", but I'm not 100% sure there.
As a general rule, I never have objections on redistributing any software I write, including source code. Hopefully someone might see my code and offer to improve it someday (I can dream, can't I?)
Posted 14 March 2007 - 06:55 AM
Do you happen to have any suggestions about the taskbar flickering I mention above? I thought it might go away if I took seconds out of the clock format (I use h:nn:ss @@@.@ usually), but it doesn't unfortunately. Once you throw in taskbar transparency it quickly becomes quite pronounced and distracting.
Posted 23 June 2007 - 08:47 AM
Systray icons do not appear, they're hidden under the background.
System resources drop to a very low level (28%), especially if system menu is skinned.
Crashes on exit, which forces an Explorer reload.
Not tested yet.